Skip to content

[General] Improvements in install dialog #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2022

Conversation

dawidgarus
Copy link
Contributor

Improvements in install dialog:

  • Refactor handling of SDLs
  • Using browser's <dialog> element for handling dialogs which comes with some advantages, like focus trap and esc to close
  • Long paths are no longer hidden under select button
  • Updated look
  • Restoring changes in scrollbar that were broken after a MR

Preview:
Screenshot from 2022-03-17 21-40-10
Screenshot from 2022-03-17 21-40-38
Screenshot from 2022-03-17 21-41-00
Screenshot from 2022-03-17 21-41-18


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

--dialog-gap: 24px;
}

.Dialog__element {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything against camelCase? ahahah
we use camel case on the other variables and CSS classnames would be good to be consistent :)

--dialog-gap: 24px;
}

.Dialog__element {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything against camelCase? ahahah
we use camel case on the other variables and CSS classnames would be good to be consistent :)

@@ -24,10 +38,14 @@ import {
Path,
Runner
} from 'src/types'
import Dialog from '../../../../components/UI/Dialog'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have relative imports configured on Heroic so you can do it like:
import Dialog from 'src/components/UI/Dialog' and so on.

@@ -24,10 +38,14 @@ import {
Path,
Runner
} from 'src/types'
import Dialog from '../../../../components/UI/Dialog'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have relative imports configured on Heroic so you can do it like:
import Dialog from 'src/components/UI/Dialog' and so on.

@@ -24,10 +38,14 @@ import {
Path,
Runner
} from 'src/types'
import Dialog from '../../../../components/UI/Dialog'
import DialogContent from '../../../../components/UI/Dialog/DialogContent'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you could have an index.ts file that imports all Dialog children's (like we are doing with sidebar, for instance) and then just import all of them on the same line:
import {DialogContent, DialogFooter, DialogHeader} from 'src/components/UI/Dialog/components'

@@ -24,10 +38,14 @@ import {
Path,
Runner
} from 'src/types'
import Dialog from '../../../../components/UI/Dialog'
import DialogContent from '../../../../components/UI/Dialog/DialogContent'
Copy link
Member

@flavioislima flavioislima Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you could have an index.ts file that imports all Dialog children's (like we are doing with sidebar, for instance) and then just import all of them on the same line:
import {DialogContent, DialogFooter, DialogHeader} from 'src/components/UI/Dialog/components'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay, now?

@flavioislima
Copy link
Member

Tested a bit here and looks good.
One improvement that we are lacking on this is actually the ability to choose the wine/proton version when installing.
that would be a good thing to add to the PR if you have the time. Otherwise we can do next :)

@dawidgarus
Copy link
Contributor Author

Added selection of wine version:
Screenshot from 2022-03-18 23-03-41

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good now. Thanks for that!

@flavioislima flavioislima merged commit 237decf into Heroic-Games-Launcher:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants