Skip to content

[General] Improvements in language selector when installing game #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

dawidgarus
Copy link
Contributor

@dawidgarus dawidgarus commented Mar 17, 2022

On game installation dialog

  • Available languages are now displayed as human readable names instead of codes
  • Attempt to select by default language that matches the language of the application interface

Preview:
Screenshot from 2022-03-17 01-18-39


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will test later!
@imLinguin take a look as well if you have time 👍🏽

@imLinguin
Copy link
Member

imLinguin commented Mar 17, 2022

Have you tested how it behaves for older games that use old depot system (V1)?
Those are mostly human readable by default.

@dawidgarus
Copy link
Contributor Author

Have you tested how it behaves for older games that use old depot system (V1)? Those are mostly human readable by default.

I didn't test it with anything other than GOG games, because I don't own any Epic game that prompts for selecting language.
But I wrote the code to fail gracefully. If translation can't be find by Intl for any reason, it will fallback to original value.
As for default selected value, it will also fallback to selecting first on list, with one caveat - it may in some edge cases default "random" language.

@imLinguin
Copy link
Member

Then it's going to work for V1 games too.

Good job ⚔️

@flavioislima flavioislima merged commit 85adecc into Heroic-Games-Launcher:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants