Skip to content

[Windows] Fix "Show log file in folder" once and for all #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2022
Merged

[Windows] Fix "Show log file in folder" once and for all #1100

merged 2 commits into from
Mar 12, 2022

Conversation

CommandMC
Copy link
Collaborator

  • Remove the workaround for showing a file, as shell.showItemInFolder actually works fine (it just didn't work back when we mixed / and \ in paths
  • Properly remove forbidden characters from log filename

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)

@CommandMC
Remove "showItemInFolder" workaround
c4db833 
Turns out this was not required, `shell.showItemInFolder`
was just not working because our paths mixed / and \
@CommandMC
Properly replace forbidden characters
7fe783c
@CommandMC CommandMC requested a review from Nocccer March 12, 2022 12:36
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 12, 2022
Nocccer
Nocccer approved these changes Mar 12, 2022
View reviewed changes
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If shell does not work on windows also with mixed / \ then we need to open a issue on electron side. They should handle such things too

@CommandMC CommandMC merged commit d09eb6a into Heroic-Games-Launcher:main Mar 12, 2022
@CommandMC CommandMC deleted the finally-fix-show-log branch March 12, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nocccer Nocccer Nocccer approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommandMC @Nocccer