Skip to content

Add more UI effects, fixes w/ user-select, other tweaks. #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 17, 2022
Merged

Conversation

8Bitz0
Copy link
Contributor

@8Bitz0 8Bitz0 commented Mar 9, 2022

Changes

  • Make the login screen more transparent.
  • Make "gamecards" have more depth.
  • Remove variables that should not be used to end note and change dependents.
  • Make blur amounts consistent with a defined variable.

Fixes

  • Could not highlight and copy URLs, logs, game description and requirements.

Screenshots

Screen Shot 2022-03-14 at 09 02 33

Screen Shot 2022-03-14 at 09 03 11

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)

@8Bitz0 8Bitz0 marked this pull request as ready for review March 10, 2022 13:26
@flavioislima
Copy link
Member

I will take a look later today.
Meanwhile, can you make both cards on login the same size?

@8Bitz0
Copy link
Contributor Author

8Bitz0 commented Mar 14, 2022

Okay, the login cards are the same size now and the screenshots have been updated.

@8Bitz0
Copy link
Contributor Author

8Bitz0 commented Mar 14, 2022

The blur might slow down low-end devices. An option to remove blur might be necessary. I will test this later today.

@8Bitz0
Copy link
Contributor Author

8Bitz0 commented Mar 14, 2022

The login screen is a little sluggish on slower devices, but it is still usable.

@flavioislima
Copy link
Member

Could not test this one, I believe it is because it's not updated with main now that I merged the others and have a few conflicts.
But I am going through the code while that 👍🏽

@8Bitz0
Copy link
Contributor Author

8Bitz0 commented Mar 15, 2022

Updated it and fixed conflicts with scrollbar colors. Tested it and things seem fine.

@flavioislima
Copy link
Member

Ok, tested here, and looks good.
My only concern is that the Continue button might get a bit hard to find for some people, especially people some kind of visual restraint. So we should have a background on it.
And the blur could also use the background color we have so it would be more consistent with the rest of the look.
But in general, looks good.

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 16, 2022
flavioislima
flavioislima previously approved these changes Mar 16, 2022
@flavioislima
Copy link
Member

This one looks good now, I will merge after fixing the conflicts 👍

@8Bitz0
Copy link
Contributor Author

8Bitz0 commented Mar 17, 2022

Oops! I didn't mean to push that to the main branch and dismiss the review. Sorry about that!

@flavioislima flavioislima merged commit 489825a into Heroic-Games-Launcher:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants