Skip to content

[UX] When a game finishes installing, sometimes you are taken to the top of the library page #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arielj opened this issue Feb 16, 2023 · 2 comments

Comments

@arielj
Copy link
Collaborator

arielj commented Feb 16, 2023

Describe the bug

When you are installing a game, if the game finishes installing and you are at a scrolled position, sometimes it takes you back to the top because the library refreshes.

This is a problem because games are being installed in the background and when you don't expect it you are taken to the top.

Add logs

Nothing relevant on the logs

Steps to reproduce

  1. Start installing a game
  2. Scroll down and wait
  3. Sometimes, when the game finishes installing, the scroll is back to the top

Expected behavior

The scroll should be preserved, without "jumping around"

Screenshots

No response

Heroic Version

Latest Stable

System Information

  • OS [e. g. "Ubuntu"]: Linux Mint

Additional information

I understand the issue is that we re-render the whole library when a game installation ends, we should only update the relevant card for the game that was just installed.

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Feb 16, 2023

I have seen similar things happen on the settings modal, but I cannot reproduce it reliably

@arielj
Copy link
Collaborator Author

arielj commented Feb 16, 2023

I understand the issue in the settings is a different one (I mean, I think it's the same issue in the sense that it's a component re-rendering, but it's not caused by a library refresh, it's some internal state of the component causing a re-render)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants