Skip to content

Add platform type to dependency check & platform api update #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

Hendrix-Shen
Copy link
Owner

Features

  • Add platform type to dependency check

Fixes

  • Fix Platform::getNamedMappingName api (forge-like)
  • Fix ModListAdapter crash1 (forge)

Footnotes

  1. But also bring breaking changes because of changes in method signatures

Signed-off-by: Hendrix-Shen <[email protected]>
Signed-off-by: Hendrix-Shen <[email protected]>
Signed-off-by: Hendrix-Shen <[email protected]>
- Use Reflection to adapt to Minecraft Forge 1.17 changes

Signed-off-by: Hendrix-Shen <[email protected]>
- But if you set it to yarn via architectury-loom, it's undetectable!

Signed-off-by: Hendrix-Shen <[email protected]>
@Hendrix-Shen Hendrix-Shen merged commit 4857a7d into dev/0.8 Oct 10, 2024
11 checks passed
@Hendrix-Shen Hendrix-Shen deleted the feat/check-platform-type branch October 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant