Skip to content

remove reusing argument on stack #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2014
Merged

remove reusing argument on stack #41

merged 2 commits into from
Oct 12, 2014

Conversation

sharow
Copy link
Contributor

@sharow sharow commented Oct 12, 2014

#39 .

only tested on linux. so this needs test on OSX and Windows.

- separate JIT logic and others (switch/case, etc)
ncannasse added a commit that referenced this pull request Oct 12, 2014
@ncannasse ncannasse merged commit 13d5c7d into HaxeFoundation:master Oct 12, 2014
@ncannasse
Copy link
Member

BTW, for OSX the JIT is disabled because the ABI requires 4 or 8 words alignement
https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/LowLevelABI/000-Introduction/introduction.html
I started working on it years ago (see the STACK_ALIGN clause) but didn't complete it. Tell me if you're interested contributing to it (either as open source contribution or paid by Haxe Foundation).

@sharow
Copy link
Contributor Author

sharow commented Oct 13, 2014

Thanks!
but I can't help about OSX issue. because I'm not Apple user.

4 words(16bytes) alignment!? ...wow:open_mouth:

@ncannasse
Copy link
Member

We could make a debug mode that check Esp % 16 before calling any C function if that works for you

@sharow
Copy link
Contributor Author

sharow commented Oct 14, 2014

Ah, feel like I can do it. but I can't promise :)

Before that, can I PullRequest few small change?

  • improve Makefile: add .o .c .h dependency. rebuild require make -B for now.
    • dependency tracking, that is GNU-Make made for.
  • add tests/ directory: test code here, and make test for test easily.

I start reading this. hmmm...

@sharow sharow deleted the fix-jit-call-by-value branch October 14, 2014 04:22
@ncannasse
Copy link
Member

Sure

aszlig added a commit to NixOS/nixpkgs that referenced this pull request Sep 10, 2015
The error was reported at HaxeFoundation/haxelib#152 and was fixed by
HaxeFoundation/neko#41 in HaxeFoundation/neko@ccc78c2, the latter being
fetchpatch'ed by us now.

This has caused the hxcpp build to fail on i686-linux with an "Invalid
array access" error.

Signed-off-by: aszlig <[email protected]>
aszlig added a commit to NixOS/nixpkgs that referenced this pull request Sep 10, 2015
The error was reported at HaxeFoundation/haxelib#152 and was fixed by
HaxeFoundation/neko#41 in HaxeFoundation/neko@ccc78c2, the latter being
fetchpatch'ed by us now.

This has caused the hxcpp build to fail on i686-linux with an "Invalid
array access" error.

Signed-off-by: aszlig <[email protected]>
(cherry picked from commit 2cc8680)
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
The error was reported at HaxeFoundation/haxelib#152 and was fixed by
HaxeFoundation/neko#41 in HaxeFoundation/neko@ccc78c2, the latter being
fetchpatch'ed by us now.

This has caused the hxcpp build to fail on i686-linux with an "Invalid
array access" error.

Signed-off-by: aszlig <[email protected]>
(cherry picked from commit 2cc8680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants