-
Notifications
You must be signed in to change notification settings - Fork 37
Reloading configuration still takes unnecessarily long #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
... instead of letting e.g. Kubernetes handle the restart. Advantages: - Much quicker restart - Kubernetes does not count a reload as a full crash See Haufe-Lexware/wicked.haufe.io#212
This had a very simple and straightforward fix: Surround calling npm start with a The same thing could be applied to the Will land in 1.0.0-rc.8. |
* adding group for the subscription/approval events (#22) * Bump to version 1.0.0-rc.5 * Fixes Haufe-Lexware/wicked.haufe.io#196 * Fixes Haufe-Lexware/wicked.haufe.io#198 * Bump to version 1.0.0-rc.6 * Update docker group to adapt to new Jenkins * Use classical pipeline again (test) * Try this on the RD jenkins * Allow loading of javascript file in static content (#24) * Change back to "docker" agent * Take out SonarQube for the time being * Log in once to make sure docker login is done * Bump to version 1.0.0-rc.7 * Enable switching off health checks * Bump to version 1.0.0-rc.8 * Infinite loop inside docker container... ... instead of letting e.g. Kubernetes handle the restart. Advantages: - Much quicker restart - Kubernetes does not count a reload as a full crash See Haufe-Lexware/wicked.haufe.io#212 * honor host (#25) * Partly fixes Haufe-Lexware/wicked.haufe.io#216
* Update jQuery, move to wicked-saml2-js (with isPassive fix) * Bump to version 1.0.0-rc.5 * Bump to 1.0.0-rc.5 * Bump to version 1.0.0-rc.6 * Test jenkins from rd * Move back to "docker" agents * Update version of package.all.json * Bump to version 1.0.0-rc.7 * Update package.all.json * Update package.all.json (added LDAP client) * Bump to version 1.0.0-rc.8 * Make containers reload themselves, without crashing See Haufe-Lexware/wicked.haufe.io#212 * Also adapt alpine Dockerfile with forever.sh * Updated package.all.json
On Kubernetes environments, the restarting of the wicked environment after a configuration reload still takes unnecessarily long, even after implementing #191.
The solution of this may lie in the Kubernetes configuration, and in the liveness and readiness probes. As shows on the wicked.box environment, restarts can be pretty quick (just 2-3 seconds usually).
Explore whether using either
nodemon
orpm2
can be a solution for the non-api
containers. Theapi
container will still need a full reload, as thegit clone
happens in the startup script of the container - at least currently.The text was updated successfully, but these errors were encountered: