feat: error handler middleware #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/wallet-service/src/api/middlewares/errorHandler.ts:26
- Consider adding unit tests for the errorHandler middleware to verify that it correctly returns a generic error message in production and a detailed error message otherwise.
if (process.env.NODE_ENV === 'production') {
| // Initialize response with default values if it hasn't been done yet. | ||
| request.response = request.response ?? {...defaultResponse}; | ||
| // Force the status code to 500 since this is an unhandled error | ||
| request.response.statusCode = 500; |
There was a problem hiding this comment.
What do you think about using the STATUS_CODE_TABLE from api/utils?
| @@ -1169,3 +1171,20 @@ describe('getWalletBalancesForTx', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| test('getTokenListFromInputsAndOutputs', () => { | |||
There was a problem hiding this comment.
Why is this test being added in this PR?
There was a problem hiding this comment.
To increase coverage since the global coverage was failing
| @@ -103,6 +103,7 @@ export const sendMessageToClient = async ( | |||
| } | |||
| }; | |||
|
|
|||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
Why?
This is apparently being used in wsAdminDisconnect
pedroferreira1
previously approved these changes
Apr 7, 2025
andreabadesso
approved these changes
Apr 7, 2025
pedroferreira1
approved these changes
Apr 7, 2025
github-project-automation
bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
r4mmer
added a commit
that referenced
this pull request
Apr 7, 2025
…-lib-v2.1.1 * origin/master: feat: error handler middleware (#234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
middydoes not have a default error handler, so unhandled errors would just return 200 with an empty body.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged