Skip to content

tests: missing tests on websocket #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

andreabadesso
Copy link
Collaborator

Motivation

Changes were made to the websocket utils without adding new tests, causing the coverage to drop below the minimum percentage, this PR should introduce new tests to the changed method

Acceptance Criteria

  • We should test the sendMessageToClient util

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso force-pushed the tests/missing-ws-tests branch from ea479dc to dca6dfd Compare May 1, 2024 19:30
@andreabadesso andreabadesso changed the title Tests/missing ws tests tests: missing tests on websocket May 1, 2024
@andreabadesso andreabadesso changed the base branch from master to refactor/common-project May 1, 2024 19:41
@andreabadesso andreabadesso self-assigned this May 1, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label May 1, 2024
@andreabadesso andreabadesso changed the base branch from refactor/common-project to master May 2, 2024 16:34
@andreabadesso andreabadesso changed the base branch from master to refactor/common-project May 2, 2024 16:35
@andreabadesso andreabadesso force-pushed the tests/missing-ws-tests branch from dca6dfd to 912fb1c Compare May 3, 2024 13:29
@andreabadesso andreabadesso changed the base branch from refactor/common-project to master May 3, 2024 13:32
@andreabadesso andreabadesso force-pushed the tests/missing-ws-tests branch from 912fb1c to 5a4d94b Compare May 3, 2024 13:33
@andreabadesso andreabadesso force-pushed the tests/missing-ws-tests branch from 5a4d94b to 5c52778 Compare May 3, 2024 13:44
Copy link

@tuliomir tuliomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By looking into the PR's checks action runs I could validate the coverage percentage, however I had no way to check how it was before this PR ( other than also checking the last commit's action runs ).

Would it be possible to add CodeCov to this monorepo? I've seen that they already have a flags feature to help with that. It would also add automatic annotations to the PR to help identify untested code.

@andreabadesso andreabadesso merged commit ea7f2b7 into master May 4, 2024
1 check passed
@andreabadesso andreabadesso deleted the tests/missing-ws-tests branch May 4, 2024 00:51
This was referenced Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants