fix: White bar below custom network #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the white bar issue observed below the custom network by removing the extra top margin in the dashboard's style.
- Removed the "marginTop: 8" property from the wrapper style to adjust layout spacing
Comments suppressed due to low confidence (1)
src/screens/Dashboard.js:193
- Verify that the removal of marginTop does not affect layout spacing on different screen sizes. Although it resolves the issue of the white bar, it's important to confirm there are no unintended layout shifts introduced elsewhere.
marginTop: 8,
| @@ -191,7 +191,6 @@ const TokensHeader = () => ( | |||
| const styles = StyleSheet.create({ | |||
| wrapper: { | |||
| flex: 1, | |||
| marginTop: 8, | |||
There was a problem hiding this comment.
Should we keep the margin, but paint the background with the same grey color as the rest?
There was a problem hiding this comment.
Implemented this on c7eabdb. Indeed it looks better.
tuliomir
force-pushed
the
fix/white-bar-network
branch
from
b095e45 to
c7eabdb
Compare
pedroferreira1
approved these changes
Apr 14, 2025
andreabadesso
approved these changes
Apr 14, 2025
obiyankenobi
approved these changes
Apr 14, 2025
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Visualization
Security Checklist
Alternatives
We could also remove the spacing entirely, but it wouldn't feel correct. See below
