-
Notifications
You must be signed in to change notification settings - Fork 26
chore: Add pt-br
as a mandatory language on CI
#673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that the 'pt-br' translation is enforced as mandatory in CI while also enabling developers to override the strict language setting locally through a CLI argument.
- Added detailed usage documentation for the update_translations script
- Introduced a CLI parameter (--strict-languages) to allow overriding mandatory languages for local development
- Updated the translation check logic to conditionally enforce strict validation based on provided languages
Files not reviewed (1)
- locale/pt-br/texts.po: Language not supported
scripts/update_translations.js
Outdated
|
||
return { | ||
isCiValidationRun: parameters['ci-validation'] || false, | ||
strictLanguages: parameters['strict-languages']?.split(',') || mandatoryTranslations, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When '--strict-languages' is provided with an empty value, splitting it will return [''] instead of defaulting to mandatoryTranslations. Consider adding a check to use mandatoryTranslations if the resulting array is empty or contains an empty string.
strictLanguages: parameters['strict-languages']?.split(',') || mandatoryTranslations, | |
strictLanguages: (parameters['strict-languages']?.split(',').filter(lang => lang) || mandatoryTranslations).length ? parameters['strict-languages']?.split(',').filter(lang => lang) : mandatoryTranslations, |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed in 31e8b02
Acceptance Criteria
pt-br
must have all translations completed to pass the CI validationSecurity Checklist