-
Notifications
You must be signed in to change notification settings - Fork 26
chore: Upgrades to latest react-native
72
#655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed by mistake |
andreabadesso
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this is approved except for the privacy file that still needs to be reviewed by @msbrogli
pedroferreira1
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When trying to setup the development environment in a new MacOS machine, some issues arose with the current build process.
Ruby version
At the moment, MacOS comes with Ruby version
2.6.x
installed. Even though it's possible to install dependencies with this version, it's a non-trivial activity that demands quite some time. A.tool-versions
was added to inform environment managers of the version necessary for this repo.React Native bug
The
boost
pod had a broken SHA256 validation that made thepod install
command fail. On version0.72.9
of React Native this bug was fixed.We took advantage of the effort to upgrade react native and advanced it all the way to the latest
0.72.17
patch. For reference, here are the official steps suggested for upgrading those versions.iOS Privacy file
Starting 12/Feb/2025, apps must contain a Privacy file with some configurations. See the official docs. Research was needed to understand this file structure and how to properly fill its mandatory keys. More about this on our related internal issue.
There's still a small chance that this privacy manifest file will be rejected by Apple on our first submission, but the expectation from the other developers' experience is that the rejection will show clearly what is missing/incorrect and how to fix it.
Acceptance Criteria
0.72.4
to0.72.17
.tool-versions
file to facilitate fixing Ruby version mismatchesPrivacyInfo.xcprivacy
file for compliance with iOS guidelinesSecurity Checklist
Additional context
In order to test a new set of
pod
dependencies, it's important to purge the current ones from local caches. For reference, here is a script that helps with this cleanup.