Skip to content

feat: rc on bump version script #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2025
Merged

feat: rc on bump version script #652

merged 4 commits into from
Feb 17, 2025

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Feb 5, 2025

Motivation

Recently we had issues using the bump script to generate the release candidate for a new version: the process had to be done in two steps, one for the actual version bump and another for the release candidate for that version. That had the downside of bumping the android build version twice, which required manual intervention to fix.

With the changes from this PR, a single call will bump the version ( major, minor or patch ) and simultaneously initiate a release candidate version.

Acceptance Criteria

  • The bump script should have an option to increment the release candidate version while also incrementing other semver version.

Example usage:

`3.0.1` -> make bump updateType=major -> `4.0.0`
`3.0.1` -> make bump updateType=major bumpRc=true -> `4.0.0-rc.1`
`3.0.1` -> make bump updateType=minor bumpRc=true -> `3.1.0-rc.1`
`3.2.1` -> make bump updateType=patch -> `3.2.2`
`3.2.1` -> make bump updateType=rc -> `3.2.1-rc.1`
`3.2.1-rc.1` -> make bump updateType=release -> `3.2.1`

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the enhancement New feature or request label Feb 5, 2025
@tuliomir tuliomir requested review from luislhl and r4mmer February 5, 2025 16:49
@tuliomir tuliomir self-assigned this Feb 5, 2025
@tuliomir tuliomir marked this pull request as ready for review February 5, 2025 16:56
@tuliomir tuliomir requested review from andreabadesso and removed request for pedroferreira1 and luislhl February 5, 2025 16:57
@tuliomir tuliomir requested a review from r4mmer February 5, 2025 18:37
@tuliomir tuliomir merged commit 1e79fb4 into master Feb 17, 2025
1 check passed
@tuliomir tuliomir deleted the feat/rc-on-bump branch February 17, 2025 16:46
@tuliomir tuliomir moved this from Waiting to be deployed to Done in Hathor Network Mar 12, 2025
@tuliomir tuliomir moved this from Done to Waiting to be deployed in Hathor Network Mar 12, 2025
@tuliomir tuliomir moved this from Waiting to be deployed to Done in Hathor Network Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants