feat: add qr code to register nano contract #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
requested changes
Aug 16, 2024
| @@ -21,6 +21,7 @@ import { | |||
| useSelector | |||
| } from 'react-redux'; | |||
| import { t } from 'ttag'; | |||
| import QRCode from 'react-native-qrcode-svg'; | |||
| <QRCodeReader | ||
| navigation={navigation} | ||
| onSuccess={onSuccess} | ||
| bottomText={t`Scan the token QR code`} |
There was a problem hiding this comment.
Missing translation for this file
| }} | ||
| > | ||
| <HathorHeader | ||
| title={t`Register Nano Contract`.toUpperCase()} |
There was a problem hiding this comment.
Can you change this to Nano Contract Registration? Or change the one in the previous screen to Register Nano Contract so they're consistent when navigating?
alexruzenhack
force-pushed
the
feat/nc-add-qr-code-reader
branch
from
6fdcf43 to
a9f7595
Compare
alexruzenhack
force-pushed
the
feat/nc-add-qr-code-reader
branch
from
a9f7595 to
bae7e18
Compare
pedroferreira1
approved these changes
Aug 23, 2024
locale/pt-br/texts.po
Outdated
|
|
||
| #: src/screens/NanoContractRegisterQrCodeScreen.js:63 | ||
| msgid "Scan the nano contract ID QR code" | ||
| msgstr "Leia o QR code Nano Contract ID" |
There was a problem hiding this comment.
Suggested change
| msgstr "Leia o QR code Nano Contract ID" | |
| msgstr "Leia o QR code do Nano Contract ID" |
andreabadesso
approved these changes
Aug 23, 2024
| #: src/screens/NanoContractRegisterQrCodeScreen.js:26 | ||
| #: src/screens/RegisterToken.js:27 src/screens/SendScanQRCode.js:87 | ||
| msgid "Manual info" | ||
| msgstr "Ручной ввод" |
There was a problem hiding this comment.
Was this an automatic translation? Maybe remove?
There was a problem hiding this comment.
No, this was already there. I believe it was only moved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Registering Nano Contract by QR Code reading:
RPReplay_Final1723759500.mov
Closes: #519
Security Checklist