feat: add nano-contract transaction actions #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexruzenhack
force-pushed
the
feat/add-nc-tx-actions
branch
7 times, most recently
from
d1771da to
175389d
Compare
andreabadesso
approved these changes
Aug 14, 2024
| import { SentIcon } from '../Icons/Sent.icon'; | ||
|
|
||
| /** | ||
| * Retrives token symbol, otherwise returns a shortened token hash. |
There was a problem hiding this comment.
Suggested change
| * Retrives token symbol, otherwise returns a shortened token hash. | |
| * Retrieves token symbol, otherwise returns a shortened token hash. |
| marginRight: 'auto', | ||
| paddingHorizontal: 16, | ||
| }, | ||
| icon: { |
| </InfoContainer> | ||
| <InfoContainer lastElement> | ||
| <TextValue bold>{callerAddr}</TextValue> | ||
| {tx.isMine |
pedroferreira1
approved these changes
Aug 17, 2024
| }; | ||
|
|
||
| const Wrapper = ({ children }) => ( | ||
| <TouchableHighlight underlayColor={COLORS.primaryOpacity30}> |
There was a problem hiding this comment.
Why a TouchableHighlight here?
There was a problem hiding this comment.
It was used by default. I think it doesn't hurt, but do you think it should be removed?
alexruzenhack
force-pushed
the
feat/add-nc-tx-actions
branch
from
175389d to
99f0703
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Closes: #518
Actions of each transaction of a Nano Contract
nc-tx-actions-review-1.mp4
Security Checklist