fix: Unable to send token by reading a QR code #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexruzenhack
changed the title
andreabadesso
approved these changes
Jul 12, 2024
tuliomir
approved these changes
Jul 12, 2024
| (stateToken) => stateToken.uid === qrcode.token.uid | ||
| ); | ||
| if (isTokenRegistered) { | ||
| if (qrcode.token.uid in this.props.tokens) { |
There was a problem hiding this comment.
suggestion(non-blocking): Add a comment explaining that this is a search into the registered tokens.
Otherwise the reader would have to search what the props.tokens mean to understand what this rule is about. This was made clearer before by the old variable name itself.
pedroferreira1
approved these changes
Jul 12, 2024
andreabadesso
pushed a commit
that referenced
this pull request
Aug 21, 2024
* fix: token registered condition after identify the qr code token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I have fixed token duplication on the Dashboard screen by transforming the registered tokens list into a map, this way we would never have a duplication. However, I failed to cover the necessary change and left one case untouched, which caused this bug.
See the previous fix at: #431
Acceptance Criteria
Closes: https://github.com/HathorNetwork/internal-issues/issues/345
Security Checklist