Skip to content

feat: add nano contract register screen [13] #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jun 18, 2024
Merged

feat: add nano contract register screen [13] #466

merged 30 commits into from
Jun 18, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Apr 15, 2024 •
edited
Loading

Acceptance Criteria

  • it should add NanoContractRegisterScreen
  • it should add action NANOCONTRACT_REGISTER_READY
  • it should improve FeedbackModal component
  • it should improve HathorModal component
  • it should refactor the transmission of ncId to NanoContractDetailsScreen
  • it should add reactions to register actions on reducer
  • it should add some small fixes and tweaks
  • It should add feedback content on first address loading

Nano Contract Registration

nc-registering-recording.mp4

First Address Loading

First Address Error

Note

It depends on:

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack changed the title feat: add nano contract register screen feat: add nano contract register screen [13] Apr 15, 2024
@alexruzenhack alexruzenhack self-assigned this Apr 15, 2024
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from a0caced to f823c2b Compare May 14, 2024 15:25
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-register-screen branch from 0beae3a to 0b47402 Compare May 14, 2024 15:34
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch 2 times, most recently from 98ffb88 to a946e8f Compare May 30, 2024 13:10
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-register-screen branch 2 times, most recently from 8ec62ff to 39aaf33 Compare May 31, 2024 19:29
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from a946e8f to 12d5cc2 Compare June 1, 2024 00:41
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-register-screen branch from 1c3f438 to cde4b2d Compare June 1, 2024 01:44
andreabadesso
andreabadesso requested changes Jun 6, 2024
View reviewed changes
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from 4d8a8a9 to 33a6d7a Compare June 6, 2024 20:01
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-register-screen branch from cde4b2d to 9629e2c Compare June 6, 2024 22:06
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from 33a6d7a to 34fffb2 Compare June 7, 2024 17:44
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-register-screen branch from b08cd79 to f5a626b Compare June 7, 2024 18:54
andreabadesso
andreabadesso requested changes Jun 12, 2024
View reviewed changes
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from 34fffb2 to a9caff1 Compare June 13, 2024 13:10
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-register-screen branch from f5a626b to 9adfec7 Compare June 13, 2024 14:17
andreabadesso
andreabadesso requested changes Jun 13, 2024
View reviewed changes
locale/pt-br/texts.po Outdated

#: src/screens/NanoContract/NanoContractRegisterScreen.js:153
msgid "Load First Addresses Error"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated.

locale/pt-br/texts.po Outdated
msgid "Contract successfully registered."
msgstr "Nano Contract registrado com sucesso."

#: src/sagas/mixins.js:33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is gone now, is an update missing on the translations?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

src/screens/NanoContract/NanoContractRegisterScreen.js Outdated
/**
* Verifies if the invalidModel of the form has an error message.
*/
function hasError(invalidModel) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be a helper?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to utils.

Base automatically changed from feat/nano-contract-transaction-details-component to master June 14, 2024 02:26
@alexruzenhack
feat: add nano contract register screen
cd41f27
@alexruzenhack
lint: comply with rules
591b198
@alexruzenhack
fix: smal fixes and tweaks
1af447f 
- Remove blueprintId from registered nano contract once state doesn't return blueprint_id in its payload
- Add firstBlock to nano contract transaction on history
- Assign state response to ncState directly
@alexruzenhack
feat: improve NanoContractTransactionsList component
bf459a6 
- Add feedback content for empty list
- Add feedback content for error on load
- Create FeedbackContent component
- Add action NANOCONTRACT_HISTORY_LOADING
- Make small tweaks on reducer
- Remove NoNanoContract component
- Refactor NanoContractsList component to use FeedbackContent component
- Do small tweaks on sagas/nanoContract
@alexruzenhack
fix: onNanoContractRegisterSuccess
df5b51f
@alexruzenhack
refactor: pass ncId in place of nc to NanoContractTransactions component
30594a8
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-register-screen branch from 0d35063 to 2072e15 Compare June 14, 2024 16:29
andreabadesso
andreabadesso requested changes Jun 17, 2024
View reviewed changes
locale/da/texts.po
@@ -1305,20 +1357,24 @@ msgstr ""
msgid "Unregister contract"
msgstr ""

#: src/components/NanoContract/NanoContractTransactionHeader.component.js:93
#. XXX: add <ArrowUpIcon /> when shrank component can be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? It was added automatically here? Weird

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was added automatically. The first time I removed it, but it has appeared again and I left it there.

pedroferreira1
pedroferreira1 reviewed Jun 17, 2024
View reviewed changes
@alexruzenhack alexruzenhack merged commit 2c66432 into master Jun 18, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the feat/nano-contract-register-screen branch June 18, 2024 16:28
andreabadesso pushed a commit that referenced this pull request Jun 24, 2024
@alexruzenhack @andreabadesso
feat: add nano contract register screen [13] (#466)
dd647df 
- Add firstBlock to nano contract transaction on history
- Feat: improve NanoContractTransactionsList component
- Add feedback content for empty list
- Add feedback content for error on load
- Create FeedbackContent component
- Remove NoNanoContract component
- Refactor NanoContractsList component to use FeedbackContent component
- Refactor: use replace on navigation in place of navigate
- Feat: add feedback content for the first address loading
- Refactor: move fetch first wallet address to saga effect
- Refactor: move fetchFirstWalletAddress to sagas/wallet
- Refactor: extract hasError to utils
- Fix: avoid show success feedback on register screen because of initialization load
@alexruzenhack alexruzenhack mentioned this pull request Oct 3, 2024
Merged
@tuliomir tuliomir mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexruzenhack @pedroferreira1 @andreabadesso