feat: add icons for nano contract transactions [8] #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2024
andreabadesso
approved these changes
Apr 5, 2024
alexruzenhack
changed the title
alexruzenhack
force-pushed
the
feat/nano-contract-list-component
branch
from
243c126 to
bf4e720
Compare
alexruzenhack
force-pushed
the
feat/nano-contract-list-component
branch
from
bf4e720 to
fea4259
Compare
alexruzenhack
force-pushed
the
feat/nc-add-icons
branch
2 times, most recently
from
37fa2b3 to
06e563d
Compare
alexruzenhack
requested review from
andreabadesso,
tuliomir and
r4mmer
and removed request for
tuliomir
r4mmer
previously approved these changes
May 14, 2024
I believe it would be useful there, yes. Aninha is preparing a Design System, which means standardization for our components. |
andreabadesso
requested changes
May 21, 2024
alexruzenhack
force-pushed
the
feat/nano-contract-list-component
branch
from
090211f to
65b0c55
Compare
alexruzenhack
force-pushed
the
feat/nc-add-icons
branch
2 times, most recently
from
1e1e19b to
6c9c73e
Compare
andreabadesso
approved these changes
May 24, 2024
alexruzenhack
force-pushed
the
feat/nc-add-icons
branch
from
6c9c73e to
12a6991
Compare
pedroferreira1
approved these changes
May 28, 2024
andreabadesso
pushed a commit
that referenced
this pull request
Jun 24, 2024
* feat(nc): add icons * refactor: move icons to /Icons and add typed properties
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the first PR of a serie to make the review easier.
Acceptance Criteria
Security Checklist