-
Notifications
You must be signed in to change notification settings - Fork 26
fix: wallet-service network error #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue you mention in the PR description has two bugs, one in the wallet service and the other in the full node facade. Which of the bugs does this PR fixes?
One other thing, after reading the issue again, I think the wallet service bug is not clear to me, I'm missing some details of it in the issue. Any received tx causes this bug? Or just if the app is in background? In which conditions does the bug happen?
I have some more questions regarding the implementation itself but it depends on the answers above.
I answer it here: https://github.com/HathorNetwork/internal-issues/issues/257#issuecomment-2007626717 But in summary, this issue solves an unhandled network error, that can happen as a normal consequence of an HTTP request. It is not related to any transaction type or the background condition of the app. |
* feat: add an abstraction method to call checkAddressMine with retry strategy * review: apply suggestions * lint: resolve rules * refactor: extract progressiveRetryRequest to helper * lint: comply with rules * review: apply suggestions * chore: add docstring to progressive retry mechanism constants * refactor: progressiveRetryRequest * lint: comply with rule * chore: remove custom maxRetries
* feat: add an abstraction method to call checkAddressMine with retry strategy * review: apply suggestions * lint: resolve rules * refactor: extract progressiveRetryRequest to helper * lint: comply with rules * review: apply suggestions * chore: add docstring to progressive retry mechanism constants * refactor: progressiveRetryRequest * lint: comply with rule * chore: remove custom maxRetries
* feat: add an abstraction method to call checkAddressMine with retry strategy * review: apply suggestions * lint: resolve rules * refactor: extract progressiveRetryRequest to helper * lint: comply with rules * review: apply suggestions * chore: add docstring to progressive retry mechanism constants * refactor: progressiveRetryRequest * lint: comply with rule * chore: remove custom maxRetries
* feat: add an abstraction method to call checkAddressMine with retry strategy * review: apply suggestions * lint: resolve rules * refactor: extract progressiveRetryRequest to helper * lint: comply with rules * review: apply suggestions * chore: add docstring to progressive retry mechanism constants * refactor: progressiveRetryRequest * lint: comply with rule * chore: remove custom maxRetries
* feat: add an abstraction method to call checkAddressMine with retry strategy * review: apply suggestions * lint: resolve rules * refactor: extract progressiveRetryRequest to helper * lint: comply with rules * review: apply suggestions * chore: add docstring to progressive retry mechanism constants * refactor: progressiveRetryRequest * lint: comply with rule * chore: remove custom maxRetries
* feat: add an abstraction method to call checkAddressMine with retry strategy * review: apply suggestions * lint: resolve rules * refactor: extract progressiveRetryRequest to helper * lint: comply with rules * review: apply suggestions * chore: add docstring to progressive retry mechanism constants * refactor: progressiveRetryRequest * lint: comply with rule * chore: remove custom maxRetries
Closes: https://github.com/HathorNetwork/internal-issues/issues/257
Acceptance Criteria
progressiveRetryRequest
which is an abstraction to apply a progressive retry strategy to async function calls; useful when making requests to wallet-service APIThe following error happens on
handlerTx
when callingwallet.checkAddressMine
:Security Checklist