Skip to content

feat: leb128 unsigned utilities #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2025
Merged

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented May 6, 2025

Acceptance Criteria

  • Add unsigned leb128 encoding to the leb128 util

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this May 6, 2025
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner May 6, 2025 17:07
@r4mmer r4mmer requested a review from glevco May 6, 2025 17:07
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (110fa5b) to head (f24439f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/leb128.ts 82.60% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   82.88%   82.89%           
=======================================
  Files          90       90           
  Lines        6937     6955   +18     
  Branches     1469     1476    +7     
=======================================
+ Hits         5750     5765   +15     
- Misses       1174     1177    +3     
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

glevco
glevco previously approved these changes May 9, 2025
pedroferreira1
pedroferreira1 previously approved these changes May 9, 2025
@r4mmer r4mmer dismissed stale reviews from pedroferreira1 and glevco via 60617a2 May 9, 2025 16:30
@r4mmer r4mmer requested review from glevco and pedroferreira1 May 9, 2025 16:32
@r4mmer r4mmer merged commit 02c2e3d into master May 9, 2025
5 checks passed
@r4mmer r4mmer deleted the feat/leb128-util-improvements branch May 9, 2025 17:14
r4mmer added a commit that referenced this pull request May 12, 2025
…ization

* origin/master:
  feat: leb128 unsigned utilities (#859)
  chore: bumped to v2.3.2 (#861)
  fix: invalid websocket schema (#850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants