Skip to content

feat: new methods that return SendTransaction #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 8, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Oct 1, 2024

Acceptance Criteria

  • Create new methods that build transactions but return the SendTransaction instance instead of automatically mining the transactions.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Oct 1, 2024
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner October 1, 2024 20:45
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.52%. Comparing base (081fb51) to head (8641a62).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   80.50%   80.52%   +0.02%     
==========================================
  Files          81       81              
  Lines        6442     6460      +18     
  Branches     1391     1400       +9     
==========================================
+ Hits         5186     5202      +16     
- Misses       1243     1245       +2     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r4mmer r4mmer requested a review from andreabadesso October 4, 2024 13:53
@r4mmer r4mmer merged commit f99f5f3 into master Oct 8, 2024
5 checks passed
@r4mmer r4mmer deleted the feat/facade-send-transaction-methods branch October 8, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants