Skip to content

feat: update nano hathor core URL for blueprint info endpoint #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pedroferreira1
Copy link
Member

Context

When I was creating a new API in the hathor core to get the blueprint source code, I had a discussion with @msbrogli about the best path for it. We ended up deciding to use /blueprint/source and, to keep consistency, we changed /blueprint (which returned the blueprint information) to /blueprint/info.

We decided to do it now that we don't have many clients using it and we can quickly update the lib and wallets with this new version.

Acceptance Criteria

  • Update blueprint information endpoint URL from hathor core

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (c3fb266) to head (9654885).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   80.50%   80.50%           
=======================================
  Files          78       78           
  Lines        6182     6182           
  Branches     1340     1349    +9     
=======================================
  Hits         4977     4977           
  Misses       1193     1193           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedroferreira1 pedroferreira1 force-pushed the feat/update-nano-hathor-core-urls branch from ad35636 to 9654885 Compare August 21, 2024 16:45
@pedroferreira1 pedroferreira1 merged commit ce15c59 into master Aug 22, 2024
4 checks passed
@pedroferreira1 pedroferreira1 deleted the feat/update-nano-hathor-core-urls branch August 22, 2024 01:55
tuliomir added a commit to HathorNetwork/hathor-wallet-headless that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants