refactor: split nano contract send method into create and mine/push #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
===========================================
+ Coverage 62.61% 79.71% +17.09%
===========================================
Files 77 77
Lines 5856 5857 +1
Branches 1217 1217
===========================================
+ Hits 3667 4669 +1002
+ Misses 2093 1171 -922
+ Partials 96 17 -79 ☔ View full report in Codecov by Sentry. |
pedroferreira1
force-pushed
the
refactor/split-send-nano-tx-method
branch
from
2abc5ba to
5163609
Compare
r4mmer
previously approved these changes
Jun 6, 2024
src/nano_contracts/utils.ts
Outdated
| * | ||
| * @param tx Transaction to sign and send | ||
| * @param pin Pin to decrypt data | ||
| * @param storage Wallet storage object | ||
| */ | ||
| export const signAndPushNCTransaction = async (tx: NanoContract, pin: string, storage: IStorage): Promise<Transaction> => { | ||
| export const signAndCreateSendTransaction = async (tx: NanoContract, pin: string, storage: IStorage): Promise<SendTransaction> => { |
There was a problem hiding this comment.
suggestion(non-blocking): rename to prepareNanoSendTransaction
While the body of the function it is not nano specific the typing indicates that this is to be used with a nano contract transaction, maybe we should reflect this in the name as well.
There was a problem hiding this comment.
Makes sense! Done bb3c613
tuliomir
previously approved these changes
Jun 6, 2024
pedroferreira1
force-pushed
the
refactor/split-send-nano-tx-method
branch
from
bb3c613 to
fa1b453
Compare
r4mmer
approved these changes
Jun 10, 2024
tuliomir
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The desktop wallet has a flow for sending tx that it expects the
SendTransactionobject because internally we handle the states of mine/push with the error handling and UI feedback for the user.Acceptance Criteria
SendTransactionobject and (ii) create, mine, and push.Security Checklist