chore: Upgrades ws
#656
Merged
chore: Upgrades ws
#656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
===========================================
+ Coverage 62.55% 79.67% +17.12%
===========================================
Files 77 77
Lines 5846 5846
Branches 1214 1227 +13
===========================================
+ Hits 3657 4658 +1001
+ Misses 2093 1171 -922
+ Partials 96 17 -79 ☔ View full report in Codecov by Sentry. |
andreabadesso
approved these changes
Jun 3, 2024
r4mmer
approved these changes
Jun 4, 2024
tuliomir
force-pushed
the
chore/upgrades-ws
branch
from
108d1a3 to
46b4e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
wsfrom7.5.9to8.17.0Notes
There is a list of breaking changes on v8's release notes, most notably the deprecation of NodeJS < 10 and changes to the lib's error handling methods.
To validate for these changes, besides this repository unit and integration tests, the built version was tested manually on the Desktop Wallet and passed the full automated test suite for the Headless Wallet.
Security Checklist