Skip to content

feat: add method to iterate over all registered nano contracts on storage #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

pedroferreira1
Copy link
Member

Acceptance Criteria

  • Add method to iterate through registered nano contracts on storage and in both implemented stores (memory and leveldb).
  • Add address to INcData.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (7a11fce) to head (0b52647).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #654       +/-   ##
===========================================
+ Coverage   62.48%   79.67%   +17.19%     
===========================================
  Files          77       77               
  Lines        5838     5846        +8     
  Branches     1214     1214               
===========================================
+ Hits         3648     4658     +1010     
+ Misses       2094     1171      -923     
+ Partials       96       17       -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedroferreira1 pedroferreira1 merged commit 284e28b into master May 28, 2024
4 checks passed
@pedroferreira1 pedroferreira1 deleted the feat/get-registered-nanos branch May 28, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants