Skip to content

feat: Integration testing #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 25, 2021
Merged

feat: Integration testing #69

merged 11 commits into from
Mar 25, 2021

Conversation

thr0wn
Copy link
Contributor

@thr0wn thr0wn commented Mar 9, 2021 •
edited
Loading

  • Increase the coverage
  • Sanitize package-lock.json
  • Solve conflicts

@thr0wn thr0wn changed the title feat: Integration tests (wip) feat: Integration testing (wip) Mar 9, 2021
@thr0wn thr0wn linked an issue Mar 9, 2021 that may be closed by this pull request
[Goal #3] Improve stability and tests of Hathor Headless #67
Closed
6 tasks
@thr0wn thr0wn self-assigned this Mar 9, 2021
@thr0wn thr0wn force-pushed the feat/integration-testing branch 4 times, most recently from c871fe9 to c736656 Compare March 9, 2021 18:04
@thr0wn thr0wn changed the title feat: Integration testing (wip) feat: Integration testing Mar 9, 2021
@thr0wn thr0wn marked this pull request as ready for review March 9, 2021 18:05
@thr0wn thr0wn force-pushed the feat/integration-testing branch 8 times, most recently from f381b8e to 7026343 Compare March 11, 2021 21:04
@pedroferreira1
Copy link
Member

See this comment here: #79 (comment)
We must have a test for the situation in this discussion.

@thr0wn
Copy link
Contributor Author

thr0wn commented Mar 12, 2021 •
edited
Loading

See this comment here: #79 (comment)
We must have a test for the situation in this discussion.

It is done here. Does this test seem fine to you?

@pedroferreira1
Copy link
Member

It is done here. Does this test seem fine to you?

It's not enough because the comment I referenced is about a PR that the /wallet/address?index was failing only when index was 0. If you haven't rebased your branch yet with dev your /wallet/address?index=0 will give you a wrong address. It's important to add the test also for index=0, see that it fails and then rebase your branch to see the test succeed.

@thr0wn thr0wn force-pushed the feat/integration-testing branch 2 times, most recently from 0baccec to 983bac8 Compare March 18, 2021 19:22
@github-actions
Copy link

Total Coverage: 76.36%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   api-docs.js100%100%100%
   api-key-auth.js0%0%0%10, 10, 10, 11, 12, 15, 3, 4, 5, 5, 5, 6, 7
   index.js73.56%72.73%77.07%105, 106, 111, 112, 112, 112, 114, 115, 119, 121, 125, 129, 130, 134, 145, 146, 159, 164, 165, 166, 170, 171, 172, 211, 212, 230, 231, 253, 254, 254, 254, 255, 257, 258, 259, 260, 260, 260, 262, 264, 288, 289, 368, 369, 399, 40, 41, 447, 447, 447, 447, 447, 448, 450, 450, 450, 450, 450, 452, 454, 454, 454, 456, 458, 463, 464, 483, 484, 517, 518, 521, 522, 528, 529, 529, 529, 530, 531, 536, 542, 543, 544, 57, 590, 61, 627, 631, 636, 637, 672, 698, 699, 70, 709, 709, 709, 71, 731, 732, 736, 737, 738, 749, 749, 749, 75, 787, 788, 789, 79, 792, 793, 794, 80, 84, 88, 89, 93
   lock.js71.43%75%85.71%40, 58, 59, 60, 64
   logger.js100%42.86%95%39
   version.js50%100%100%8
src/utils
   generate_words.js100%100%0%10, 12

3 similar comments
@github-actions
Copy link

Total Coverage: 76.36%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   api-docs.js100%100%100%
   api-key-auth.js0%0%0%10, 10, 10, 11, 12, 15, 3, 4, 5, 5, 5, 6, 7
   index.js73.56%72.73%77.07%105, 106, 111, 112, 112, 112, 114, 115, 119, 121, 125, 129, 130, 134, 145, 146, 159, 164, 165, 166, 170, 171, 172, 211, 212, 230, 231, 253, 254, 254, 254, 255, 257, 258, 259, 260, 260, 260, 262, 264, 288, 289, 368, 369, 399, 40, 41, 447, 447, 447, 447, 447, 448, 450, 450, 450, 450, 450, 452, 454, 454, 454, 456, 458, 463, 464, 483, 484, 517, 518, 521, 522, 528, 529, 529, 529, 530, 531, 536, 542, 543, 544, 57, 590, 61, 627, 631, 636, 637, 672, 698, 699, 70, 709, 709, 709, 71, 731, 732, 736, 737, 738, 749, 749, 749, 75, 787, 788, 789, 79, 792, 793, 794, 80, 84, 88, 89, 93
   lock.js71.43%75%85.71%40, 58, 59, 60, 64
   logger.js100%42.86%95%39
   version.js50%100%100%8
src/utils
   generate_words.js100%100%0%10, 12

@github-actions
Copy link

Total Coverage: 76.36%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   api-docs.js100%100%100%
   api-key-auth.js0%0%0%10, 10, 10, 11, 12, 15, 3, 4, 5, 5, 5, 6, 7
   index.js73.56%72.73%77.07%105, 106, 111, 112, 112, 112, 114, 115, 119, 121, 125, 129, 130, 134, 145, 146, 159, 164, 165, 166, 170, 171, 172, 211, 212, 230, 231, 253, 254, 254, 254, 255, 257, 258, 259, 260, 260, 260, 262, 264, 288, 289, 368, 369, 399, 40, 41, 447, 447, 447, 447, 447, 448, 450, 450, 450, 450, 450, 452, 454, 454, 454, 456, 458, 463, 464, 483, 484, 517, 518, 521, 522, 528, 529, 529, 529, 530, 531, 536, 542, 543, 544, 57, 590, 61, 627, 631, 636, 637, 672, 698, 699, 70, 709, 709, 709, 71, 731, 732, 736, 737, 738, 749, 749, 749, 75, 787, 788, 789, 79, 792, 793, 794, 80, 84, 88, 89, 93
   lock.js71.43%75%85.71%40, 58, 59, 60, 64
   logger.js100%42.86%95%39
   version.js50%100%100%8
src/utils
   generate_words.js100%100%0%10, 12

@github-actions
Copy link

Total Coverage: 76.36%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   api-docs.js100%100%100%
   api-key-auth.js0%0%0%10, 10, 10, 11, 12, 15, 3, 4, 5, 5, 5, 6, 7
   index.js73.56%72.73%77.07%105, 106, 111, 112, 112, 112, 114, 115, 119, 121, 125, 129, 130, 134, 145, 146, 159, 164, 165, 166, 170, 171, 172, 211, 212, 230, 231, 253, 254, 254, 254, 255, 257, 258, 259, 260, 260, 260, 262, 264, 288, 289, 368, 369, 399, 40, 41, 447, 447, 447, 447, 447, 448, 450, 450, 450, 450, 450, 452, 454, 454, 454, 456, 458, 463, 464, 483, 484, 517, 518, 521, 522, 528, 529, 529, 529, 530, 531, 536, 542, 543, 544, 57, 590, 61, 627, 631, 636, 637, 672, 698, 699, 70, 709, 709, 709, 71, 731, 732, 736, 737, 738, 749, 749, 749, 75, 787, 788, 789, 79, 792, 793, 794, 80, 84, 88, 89, 93
   lock.js71.43%75%85.71%40, 58, 59, 60, 64
   logger.js100%42.86%95%39
   version.js50%100%100%8
src/utils
   generate_words.js100%100%0%10, 12

@thr0wn thr0wn force-pushed the feat/integration-testing branch 9 times, most recently from 618e081 to 6d26bd4 Compare March 19, 2021 14:14
@thr0wn thr0wn mentioned this pull request Mar 19, 2021
Closed
@thr0wn thr0wn force-pushed the feat/integration-testing branch 5 times, most recently from b87f2fd to 62ba831 Compare March 19, 2021 18:50
pedroferreira1
pedroferreira1 approved these changes Mar 22, 2021
View reviewed changes
@pedroferreira1 pedroferreira1 requested a review from msbrogli March 22, 2021 16:39
@thr0wn thr0wn force-pushed the feat/integration-testing branch from 62ba831 to c26a2f4 Compare March 22, 2021 17:06
@HathorNetwork HathorNetwork deleted a comment from codecov-io Mar 22, 2021
@thr0wn thr0wn merged commit eda7a51 into dev Mar 25, 2021
@thr0wn thr0wn deleted the feat/integration-testing branch March 25, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbrogli msbrogli msbrogli approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@thr0wn thr0wn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Goal #3] Improve stability and tests of Hathor Headless
3 participants
@thr0wn @pedroferreira1 @msbrogli