Skip to content

feat: get best block height from features API #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Apr 25, 2025

Motivation

Get mining info API always returns height 0 on PoA side-dags and not the best chain height.

Acceptance Criteria

  • Get best chain height from features API.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Apr 25, 2025
@r4mmer r4mmer moved this from Todo to In Progress (WIP) in Hathor Network Apr 25, 2025
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (6f3d6e9) to head (dd66396).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   90.42%   90.42%           
=======================================
  Files          56       56           
  Lines        2422     2423    +1     
  Branches      452      451    -1     
=======================================
+ Hits         2190     2191    +1     
  Misses        216      216           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r4mmer r4mmer marked this pull request as ready for review April 30, 2025 15:29
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner April 30, 2025 15:29
@r4mmer r4mmer moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Apr 30, 2025
@r4mmer r4mmer requested a review from luislhl April 30, 2025 15:30
@pedroferreira1 pedroferreira1 requested review from tuliomir and removed request for luislhl April 30, 2025 15:54
@pedroferreira1 pedroferreira1 moved this from In Progress (Done) to In Review (WIP) in Hathor Network Apr 30, 2025
@tuliomir tuliomir moved this from In Review (WIP) to In Review (Done) in Hathor Network Apr 30, 2025
@r4mmer r4mmer merged commit fb297d1 into master May 2, 2025
8 checks passed
@r4mmer r4mmer deleted the feat/block-height-from-feature-api branch May 2, 2025 14:03
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network May 2, 2025
@r4mmer r4mmer moved this from Waiting to be deployed to Done in Hathor Network May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants