Skip to content

feat: include the wallet-id responsible for the log #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Aug 23, 2024

Acceptance Criteria

  • Include the wallet-id on the logs where possible

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer requested a review from tuliomir August 23, 2024 01:51
@r4mmer r4mmer self-assigned this Aug 23, 2024
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner August 23, 2024 01:51
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 86.02151% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.86%. Comparing base (4a9b4d7) to head (128116a).
Report is 1 commits behind head on master.

Files Patch % Lines
...rc/controllers/fireblocks/fireblocks.controller.js 70.00% 3 Missing ⚠️
src/controllers/index.controller.js 60.00% 2 Missing ⚠️
src/helpers/tx.helper.js 33.33% 2 Missing ⚠️
src/services/fireblocks.service.js 66.66% 2 Missing ⚠️
src/app.js 66.66% 1 Missing ⚠️
src/controllers/hsm/hsm.controller.js 88.88% 1 Missing ⚠️
src/services/logger.service.js 92.85% 1 Missing ⚠️
src/services/wallets.service.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   89.71%   89.86%   +0.14%     
==========================================
  Files          51       53       +2     
  Lines        2178     2219      +41     
  Branches      415      419       +4     
==========================================
+ Hits         1954     1994      +40     
- Misses        207      208       +1     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r4mmer r4mmer linked an issue Aug 23, 2024 that may be closed by this pull request
@r4mmer r4mmer force-pushed the feat/walletid-logger branch from e85fa71 to 8964127 Compare August 23, 2024 19:20
@r4mmer r4mmer merged commit 48f78b9 into master Aug 26, 2024
8 checks passed
@r4mmer r4mmer deleted the feat/walletid-logger branch August 27, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Inlcude wallet-id on logs
3 participants