Skip to content

feat: allow wallets on error state for stop API #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Aug 22, 2024

Acceptance Criteria

  • Allow wallets on ERROR state for stop API

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer requested a review from tuliomir August 22, 2024 17:08
@r4mmer r4mmer self-assigned this Aug 22, 2024
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner August 22, 2024 17:08
@r4mmer r4mmer linked an issue Aug 22, 2024 that may be closed by this pull request
pedroferreira1
pedroferreira1 previously approved these changes Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (bcd6c5d) to head (287574f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   89.59%   89.71%   +0.11%     
==========================================
  Files          51       51              
  Lines        2173     2178       +5     
  Branches      413      415       +2     
==========================================
+ Hits         1947     1954       +7     
+ Misses        209      207       -2     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tuliomir
tuliomir previously approved these changes Aug 22, 2024
@r4mmer r4mmer dismissed stale reviews from tuliomir and pedroferreira1 via 8f88906 August 23, 2024 14:05
@r4mmer r4mmer merged commit 4a9b4d7 into master Aug 26, 2024
8 checks passed
@r4mmer r4mmer deleted the feat/stop-errored-wallets branch August 26, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow stopping wallets on ERROR state
3 participants