-
Notifications
You must be signed in to change notification settings - Fork 25
feat: data token admin #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 87.33% 87.35% +0.02%
==========================================
Files 51 51
Lines 2147 2151 +4
Branches 404 406 +2
==========================================
+ Hits 1875 1879 +4
Misses 247 247
Partials 25 25 ☔ View full report in Codecov by Sentry. |
r4mmer
commented
Jun 17, 2024
r4mmer
commented
Jun 17, 2024
r4mmer
commented
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's missing the api docs
andreabadesso
previously approved these changes
Jun 17, 2024
andreabadesso
previously approved these changes
Jun 18, 2024
pedroferreira1
previously approved these changes
Jun 18, 2024
386d1d1
pedroferreira1
approved these changes
Jun 18, 2024
andreabadesso
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist