Skip to content

feat: data token admin #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 18, 2024
Merged

feat: data token admin #452

merged 11 commits into from
Jun 18, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Jun 14, 2024

Acceptance Criteria

  • Include options to add data output on the headless

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer requested a review from pedroferreira1 as a code owner June 14, 2024 22:21
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (074f05f) to head (0491574).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   87.33%   87.35%   +0.02%     
==========================================
  Files          51       51              
  Lines        2147     2151       +4     
  Branches      404      406       +2     
==========================================
+ Hits         1875     1879       +4     
  Misses        247      247              
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r4mmer r4mmer requested a review from andreabadesso June 17, 2024 15:22
@r4mmer r4mmer self-assigned this Jun 17, 2024
Copy link
Member

@pedroferreira1 pedroferreira1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the api docs

andreabadesso
andreabadesso previously approved these changes Jun 17, 2024
andreabadesso
andreabadesso previously approved these changes Jun 18, 2024
pedroferreira1
pedroferreira1 previously approved these changes Jun 18, 2024
@r4mmer r4mmer dismissed stale reviews from pedroferreira1 and andreabadesso via 386d1d1 June 18, 2024 00:43
@r4mmer r4mmer merged commit 4648701 into master Jun 18, 2024
@r4mmer r4mmer deleted the feat/data-token-admin branch June 18, 2024 02:13
@r4mmer r4mmer restored the feat/data-token-admin branch June 18, 2024 02:13
@r4mmer r4mmer deleted the feat/data-token-admin branch August 21, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants