-
Notifications
You must be signed in to change notification settings - Fork 25
feat: allow setting tx mining service apikey #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #175 +/- ##
==========================================
+ Coverage 85.78% 85.84% +0.06%
==========================================
Files 19 19
Lines 647 650 +3
Branches 132 133 +1
==========================================
+ Hits 555 558 +3
Misses 83 83
Partials 9 9
Continue to review full report at Codecov.
|
The code for me is good, just two considerations:
|
08df595
to
b3e8a5c
Compare
… into feat/allow-setting-tx-mining-service-apikey
I'm ignoring Codecov report this time because they are complaining about some |
Acceptance Criteria
Security Checklist