-
Notifications
You must be signed in to change notification settings - Fork 0
feat: bigint support #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
r4mmer
requested changes
Mar 17, 2025
packages/hathor-rpc-handler/src/rpcMethods/sendNanoContractTx.ts
Outdated
Show resolved
Hide resolved
cca0d0a
to
8e274f4
Compare
packages/hathor-rpc-handler/src/rpcMethods/sendNanoContractTx.ts
Outdated
Show resolved
Hide resolved
pedroferreira1
approved these changes
Mar 20, 2025
r4mmer
requested changes
Mar 24, 2025
packages/hathor-rpc-handler/src/rpcMethods/sendNanoContractTx.ts
Outdated
Show resolved
Hide resolved
packages/hathor-rpc-handler/src/rpcMethods/sendNanoContractTx.ts
Outdated
Show resolved
Hide resolved
2a8db7a
to
791fd97
Compare
…a transform for that
r4mmer
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All numbers in rpc methods that can be big numbers should come as strings in the RPC requests, but we should convert them to BigInt before sending to the rpc-lib clients.
Acceptance Criteria
htr_sendNanoContractTx
should accept strings as nano contract action amounts, parse and return BigInt objects to the clients.htr_createToken
should accept a string with the number as the amount and return a BigInt object to the client.htr_sendTransaction
should throw a specific error if an error occurs in the prepareTx phase so the clients know whether to show the retry button or not.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged