Skip to content

feat: bigint support #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 1, 2025
Merged

feat: bigint support #33

merged 22 commits into from
Apr 1, 2025

Conversation

andreabadesso
Copy link
Collaborator

@andreabadesso andreabadesso commented Mar 17, 2025

Motivation

All numbers in rpc methods that can be big numbers should come as strings in the RPC requests, but we should convert them to BigInt before sending to the rpc-lib clients.

Acceptance Criteria

  • htr_sendNanoContractTx should accept strings as nano contract action amounts, parse and return BigInt objects to the clients.
  • htr_createToken should accept a string with the number as the amount and return a BigInt object to the client.
  • htr_sendTransaction should throw a specific error if an error occurs in the prepareTx phase so the clients know whether to show the retry button or not.
  • We should have tests to cover all those scenarios.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Mar 17, 2025
@andreabadesso andreabadesso added the enhancement New feature or request label Mar 17, 2025
@andreabadesso andreabadesso moved this from Todo to In Progress (WIP) in Hathor Network Mar 17, 2025
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 17, 2025
@andreabadesso andreabadesso mentioned this pull request Mar 17, 2025
3 tasks
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 17, 2025
@andreabadesso andreabadesso requested a review from r4mmer March 17, 2025 18:05
@andreabadesso andreabadesso moved this from In Review (WIP) to In Progress (WIP) in Hathor Network Mar 20, 2025
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 20, 2025
@andreabadesso andreabadesso moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 20, 2025
@r4mmer r4mmer moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 24, 2025
@andreabadesso andreabadesso moved this from In Review (Done) to In Progress (WIP) in Hathor Network Mar 25, 2025
@andreabadesso andreabadesso moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 27, 2025
@andreabadesso andreabadesso requested a review from r4mmer March 28, 2025 11:52
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 31, 2025
@andreabadesso andreabadesso moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 31, 2025
@andreabadesso andreabadesso merged commit b20885e into master Apr 1, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Apr 1, 2025
@andreabadesso andreabadesso moved this from Waiting to be deployed to Done in Hathor Network May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants