-
Notifications
You must be signed in to change notification settings - Fork 30
refactor(indexes): Optimize RocksDBAddressIndex to handle pagination in O(log n) #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pedroferreira1
merged 4 commits into
master
from
refactor/address-history-api-performance
Mar 20, 2024
Merged
refactor(indexes): Optimize RocksDBAddressIndex to handle pagination in O(log n) #978
pedroferreira1
merged 4 commits into
master
from
refactor/address-history-api-performance
Mar 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 85.09% 85.16% +0.06%
==========================================
Files 294 294
Lines 22789 22797 +8
Branches 3432 3434 +2
==========================================
+ Hits 19393 19415 +22
+ Misses 2713 2702 -11
+ Partials 683 680 -3 ☔ View full report in Codecov by Sentry. |
glevco
previously approved these changes
Mar 15, 2024
d3511d4
to
a2ee438
Compare
Base automatically changed from
fix/memory-tx-group-index-wrong-order
to
master
March 15, 2024 20:42
msbrogli
previously approved these changes
Mar 15, 2024
The merge-base changed after approval.
88ca592
to
103ca7d
Compare
glevco
previously approved these changes
Mar 15, 2024
msbrogli
previously approved these changes
Mar 19, 2024
… a specific hash without O(n) performance
da98aaa
to
cc331cf
Compare
msbrogli
approved these changes
Mar 20, 2024
glevco
approved these changes
Mar 20, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We had some users with wallets that had many transactions in single addresses, then the API request
address_history
got really slow.More details here
Acceptance Criteria
get_sorted_from_key
method of tx group index to find the first tx to return the iterator from.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged