feat(feature-activation): configure new NOP features on mainnet #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
==========================================
- Coverage 85.21% 85.15% -0.06%
==========================================
Files 292 292
Lines 22661 22661
Branches 3413 3413
==========================================
- Hits 19310 19297 -13
- Misses 2683 2690 +7
- Partials 668 674 +6 ☔ View full report in Codecov by Sentry. |
jansegre
reviewed
Feb 22, 2024
msbrogli
approved these changes
Feb 22, 2024
jansegre
approved these changes
Feb 22, 2024
This was referenced Feb 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since the miners did not update their nodes for the last test, we have to introduce new NOP features to test that bit signaling is working correctly.
The features are configured to start in approximately 1 week from now, and the voting period will last for 10 weeks, giving enough time for miners to udpate.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged