-
Notifications
You must be signed in to change notification settings - Fork 29
feat(cli): Add feature flag and CLI parameters for Nano Contracts #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
157bd88
to
b50a1b7
Compare
b50a1b7
to
2df861a
Compare
2df861a
to
a9baf64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just looks like some tests that check for the settings have to be updated. Also, nano_testnet.yml
does not have a .py
module counterpart, I think it's fine tho, I'll open a PR to remove those (done, #942), since they have been deprecated for a while now.
a9baf64
to
bf64751
Compare
bf64751
to
e3246ca
Compare
e3246ca
to
a7cf1ba
Compare
Fixed! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 85.34% 85.31% -0.04%
==========================================
Files 290 291 +1
Lines 22511 22526 +15
Branches 3388 3391 +3
==========================================
+ Hits 19212 19217 +5
- Misses 2628 2634 +6
- Partials 671 675 +4 ☔ View full report in Codecov by Sentry. |
Motivation
Add a feature flag and CLI parameters to run a localnet with NanoContracts enabled. These changes are temporary but they are useful to allow beta testers to experiment with Nano Contracts.
The activation of Nano Contracts for both mainnet and testnet will occur through the Feature Activation. The proper configuration will take place in a future PR.
Acceptance Criteria
nano-testnet
.--nano-testnet
that will run the full node on a localnet.nano-testnet
to use the same version bytes as the testnet but different genesis.ENABLE_NANO_CONTRACTS
which is disabled by default except on thenano-testnet
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged