feat(cli): mark sync-v2 parameters as safe and deprecate --x-* ones #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
force-pushed
the
feat/cli-mark-sync-v2-safe
branch
from
e2de03c to
a9ca056
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
==========================================
+ Coverage 85.32% 85.42% +0.10%
==========================================
Files 290 290
Lines 22454 22460 +6
Branches 3377 3379 +2
==========================================
+ Hits 19158 19186 +28
+ Misses 2624 2609 -15
+ Partials 672 665 -7 ☔ View full report in Codecov by Sentry. |
jansegre
force-pushed
the
feat/cli-mark-sync-v2-safe
branch
from
a9ca056 to
e0e3e26
Compare
glevco
approved these changes
Jan 29, 2024
jansegre
force-pushed
the
feat/cli-mark-sync-v2-safe
branch
from
e0e3e26 to
94696f2
Compare
2 tasks
msbrogli
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On the previous release sync-v2 was available as "experimental" and was marked as "unsafe", our tests showed it ran really well, so in this release it is being marked as "safe", making it more user friendly to enable.
Acceptance Criteria
--x-sync-v2-onlyand--x-sync-bridgeare still accepted but give a warning saying they're deprecated and will be removed in a later release (possiblyv0.60.0)--sync-v2-onlyand--sync-bridgeare added and have the same meaning as the--x-*variants.--x-*variants, meaning--x-sync-v2-onlyand--sync-v2-onlycan't be used at the same time, and as long as one of them is true, the value used is trueChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged