refactor(settings): remove some calls to HathorSettings #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 85.18% 85.31% +0.13%
==========================================
Files 285 285
Lines 22370 22368 -2
Branches 3371 3371
==========================================
+ Hits 19055 19083 +28
+ Misses 2641 2619 -22
+ Partials 674 666 -8 ☔ View full report in Codecov by Sentry. |
glevco
changed the title
msbrogli
previously approved these changes
Jan 12, 2024
jansegre
previously approved these changes
Jan 13, 2024
glevco
force-pushed
the
refactor/rename-get-settings
branch
from
28d38c0 to
b4fd2a2
Compare
glevco
force-pushed
the
refactor/settings/remove-global-usages
branch
from
c8026ec to
76855c0
Compare
glevco
force-pushed
the
refactor/rename-get-settings
branch
from
b4fd2a2 to
273d228
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
jansegre
approved these changes
Jan 16, 2024
msbrogli
approved these changes
Jan 17, 2024
glevco
force-pushed
the
refactor/settings/remove-global-usages
branch
from
76855c0 to
39aa104
Compare
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Continue with settings refactors.
Acceptance Criteria
HathorSettings(), changing them toget_global_settings().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged