Skip to content

feat(feature-activation): configure NOP features on mainnet #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jan 5, 2024

Depends on #903

Motivation

Configure NOP features for Feature Activation on mainnet, so we can test the process there, according to the Phased Testing plan.

Acceptance Criteria

  • Enable Feature Activation usage on mainnet.
  • Configure NOP_FEATURE_1 and NOP_FEATURE_2 on mainnet.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eaf76bd) 85.22% compared to head (58f40ab) 85.35%.
Report is 1 commits behind head on master.

Files Patch % Lines
hathor/p2p/manager.py 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   85.22%   85.35%   +0.13%     
==========================================
  Files         285      285              
  Lines       22368    22365       -3     
  Branches     3371     3369       -2     
==========================================
+ Hits        19063    19090      +27     
+ Misses       2631     2607      -24     
+ Partials      674      668       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 29b013e to 815eb6f Compare January 5, 2024 23:26
@glevco glevco marked this pull request as ready for review January 6, 2024 01:23
jansegre
jansegre previously approved these changes Jan 8, 2024
@glevco glevco force-pushed the feat/feature-activation/decrese-evaluation-interval branch from e4235bf to 974b7e2 Compare January 9, 2024 15:02
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 815eb6f to 7077f40 Compare January 9, 2024 15:03
@glevco glevco force-pushed the feat/feature-activation/decrese-evaluation-interval branch from 974b7e2 to 7904143 Compare January 12, 2024 15:55
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 7077f40 to a37fdb8 Compare January 12, 2024 15:56
@glevco
Copy link
Contributor Author

glevco commented Jan 12, 2024

@jansegre I've pushed the start of the process 1 more week, so it starts 2 weeks from now, to buy time for the next release and talking to our miner partners.

msbrogli
msbrogli previously approved these changes Jan 12, 2024
@glevco glevco force-pushed the feat/feature-activation/decrese-evaluation-interval branch from 7904143 to 1b2b955 Compare January 15, 2024 18:41
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 64d0a86 to 47d61df Compare January 15, 2024 18:42
Base automatically changed from feat/feature-activation/decrese-evaluation-interval to master January 16, 2024 00:31
@jansegre jansegre dismissed stale reviews from msbrogli and themself January 16, 2024 00:31

The base branch was changed.

@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 47d61df to efb8df1 Compare January 16, 2024 01:58
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from b48096e to 1c69286 Compare January 18, 2024 21:51
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 1c69286 to 58f40ab Compare January 18, 2024 23:38
@glevco glevco merged commit 6a43a05 into master Jan 19, 2024
@glevco glevco deleted the feat/feature-activation/mainnet-nop-features branch January 19, 2024 01:18
@glevco glevco restored the feat/feature-activation/mainnet-nop-features branch January 19, 2024 01:28
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants