Skip to content

fix(reactor): fix reactor initialization on CLI tools #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Dec 27, 2023

Motivation

There was a regression in one of the latest refactors related to reactors. The get function is being called in CLI tools instead of the initialize one, which would be correct.

Acceptance Criteria

  • Change get_global_reactor() to initialize_global_reactor() on CLI tools.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Dec 27, 2023
@glevco glevco marked this pull request as ready for review December 27, 2023 16:56
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0040f51) 85.27% compared to head (6fbe253) 85.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   85.27%   85.34%   +0.06%     
==========================================
  Files         284      284              
  Lines       22330    22330              
  Branches     3367     3367              
==========================================
+ Hits        19043    19058      +15     
+ Misses       2614     2603      -11     
+ Partials      673      669       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit c0364ba into master Dec 28, 2023
@glevco glevco deleted the fix/reactor-init branch December 28, 2023 14:50
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants