Skip to content

fix: remove unused NOP features #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: remove unused NOP features #901

merged 1 commit into from
Dec 21, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Dec 21, 2023

Motivation

Clear all metadata related to the unused first Feature Activation Phased Testing.

Acceptance Criteria

  • Remove NOP features from testnet config files.
  • Add migration for cleaning first Phased Testing metadata.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Dec 21, 2023
@glevco glevco self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8261720) 85.46% compared to head (f6dd5c9) 85.26%.

Files Patch % Lines
...on/storage/migrations/remove_first_nop_features.py 48.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   85.46%   85.26%   -0.20%     
==========================================
  Files         283      284       +1     
  Lines       22305    22330      +25     
  Branches     3363     3367       +4     
==========================================
- Hits        19062    19040      -22     
- Misses       2580     2617      +37     
- Partials      663      673      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jansegre
jansegre previously approved these changes Dec 21, 2023
@glevco glevco force-pushed the fix/remove-nop-features branch from 284146c to f6dd5c9 Compare December 21, 2023 21:19
@glevco glevco marked this pull request as ready for review December 21, 2023 21:26
@glevco glevco requested a review from msbrogli as a code owner December 21, 2023 21:26
@glevco glevco merged commit 7eab19b into master Dec 21, 2023
@glevco glevco deleted the fix/remove-nop-features branch December 21, 2023 22:15
This was referenced Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants