feat(sync-v1): remove SendDataPush queue #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
force-pushed
the
feat/remove-data-push
branch
from
e218c13 to
61327ba
Compare
msbrogli
approved these changes
Dec 8, 2023
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
==========================================
+ Coverage 85.28% 85.34% +0.06%
==========================================
Files 283 283
Lines 22416 22331 -85
Branches 3397 3380 -17
==========================================
- Hits 19118 19059 -59
+ Misses 2611 2597 -14
+ Partials 687 675 -12 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Code is out of use since #886
Acceptance Criteria
SendDataPushclass,send_data_queueproperty and related code.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged