Skip to content

feat(sync-v2): Always relay vertices in real-time if the peer requested it #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Nov 9, 2023

Motivation

The logic to decide whether we would relay real-time vertices to peer used by in the sender. But now we moved it to the client, which means each peer can independently decide whether they want to receive real-time vertices or not.

This PR removes an outdated condition that was preventing the peer to decide.

Acceptance Criteria

  1. Remove is_synced() verification of send_tx_to_peer_if_possible()

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner November 9, 2023 16:31
@msbrogli msbrogli self-assigned this Nov 9, 2023
@msbrogli msbrogli requested a review from glevco November 9, 2023 16:31
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45281a2) 85.33% compared to head (b6cab8b) 85.31%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   85.33%   85.31%   -0.03%     
==========================================
  Files         282      282              
  Lines       22269    22267       -2     
  Branches     3367     3366       -1     
==========================================
- Hits        19003    18996       -7     
- Misses       2597     2602       +5     
  Partials      669      669              
Files Coverage Δ
hathor/p2p/sync_v2/agent.py 78.52% <ø> (-1.01%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msbrogli msbrogli merged commit d5be7b9 into master Nov 9, 2023
@msbrogli msbrogli deleted the feat/sync-v2-relay branch November 9, 2023 19:23
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants