fix(mining): Fix block template not checking for MAX_FUTURE_TIMESTAMP_ALLOWED #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
previously approved these changes
Oct 20, 2023
jansegre
previously approved these changes
Oct 20, 2023
msbrogli
force-pushed
the
fix/block-template-timestamp
branch
from
ee9e155 to
8b6322a
Compare
jansegre
approved these changes
Oct 20, 2023
msbrogli
force-pushed
the
fix/block-template-timestamp
branch
from
8b6322a to
4adb93f
Compare
glevco
approved these changes
Oct 20, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 84.58% 84.54% -0.05%
==========================================
Files 269 269
Lines 22223 22234 +11
Branches 3398 3399 +1
==========================================
Hits 18797 18797
- Misses 2759 2766 +7
- Partials 667 671 +4
☔ View full report in Codecov by Sentry. |
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Some flaky tests using simulator were failing with the following error:
hathor.exception.InvalidNewTransaction: Ignoring transaction in the future.Why?
Because a miner was trying to push a block with a timestamp set too far in the future.
Why?
Because
HathorManager.generate_mining_block()was returning a block template with an invalid timestamp.Why?
After a chain of calls started by
Hathor.generate_mining_block(), the method_make_block_template()was called. This method was not taking into consideration theMAX_FUTURE_TIMESTAMP_ALLOWEDwhen calculating the maximum allowed timestamp.Acceptance criteria
BlockTemplateErrorandBlockTemplateTimestampError.HathorManager._make_block_template()to takeMAX_FUTURE_TIMESTAMP_ALLOWEDinto consideration when calculatingmax_timestamp.hathor.simulator.GeometricMinerto handle theBlockTemplateTimestampErrortrying again in 5 seconds.