Skip to content

tests: fix flaky log test #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023
Merged

tests: fix flaky log test #821

merged 1 commit into from
Oct 20, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 20, 2023

Motivation

The test_non_signaling_features_warning() test was flaky. This PR tries to fix this. Before, it used capture_logs() from structlog. I believe the flakiness reason was related to that (maybe because it's not thread-safe).

Acceptance Criteria

  • Change test_non_signaling_features_warning() to use a standard mock instead of capturing logs.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the tests label Oct 20, 2023
@glevco glevco self-assigned this Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f515f6d) 84.60% compared to head (613d0ac) 84.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   84.60%   84.55%   -0.05%     
==========================================
  Files         269      269              
  Lines       22223    22223              
  Branches     3398     3398              
==========================================
- Hits        18802    18791      -11     
- Misses       2755     2762       +7     
- Partials      666      670       +4     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review October 20, 2023 14:17
@msbrogli msbrogli merged commit 613d0ac into master Oct 20, 2023
@msbrogli msbrogli deleted the tests/bit-signaling-log branch October 20, 2023 18:00
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants