test(sync-v2): Fix seed in some sync-v2 tests while it's under testing #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
test/sync-v2-fixed-seed
branch
from
e07b891 to
121a835
Compare
glevco
approved these changes
Oct 18, 2023
msbrogli
force-pushed
the
test/sync-v2-fixed-seed
branch
from
121a835 to
bed37ef
Compare
glevco
previously approved these changes
Oct 18, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 84.60% 84.56% -0.05%
==========================================
Files 266 266
Lines 22131 22131
Branches 3380 3380
==========================================
- Hits 18723 18714 -9
- Misses 2745 2752 +7
- Partials 663 665 +2 ☔ View full report in Codecov by Sentry. |
msbrogli
force-pushed
the
test/fix-flaky-test_sync_enabled
branch
from
a9b2a4c to
3c9bac8
Compare
jansegre
previously approved these changes
Oct 18, 2023
msbrogli
dismissed stale reviews from jansegre and glevco
The base branch was changed.
jansegre
previously approved these changes
Oct 18, 2023
msbrogli
force-pushed
the
test/sync-v2-fixed-seed
branch
from
bed37ef to
dbfb9ec
Compare
jansegre
approved these changes
Oct 18, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sync-v2 is still under testing. It's already known that it fails in some edge cases. So, this PR fixes a seed for some sync-v2 tests that have been failing randomly.
Acceptance Criteria
tests/p2p/test_sync_v2.py.tests/simulation/test_simulator.py::SyncV2RandomSimulatorTestCase.tests/simulation/test_simulator.py::SyncBridgeRandomSimulatorTestCase.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged