test(sync-v1): Reset rate limit hit counter after simulation #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
test/sync-v1-rate-limit
branch
from
882ff50 to
185e114
Compare
jansegre
approved these changes
Oct 17, 2023
msbrogli
force-pushed
the
test/sync-v1-rate-limit
branch
from
185e114 to
889bf5d
Compare
This was referenced Oct 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix flaky test
FAILED tests/p2p/test_sync_rate_limiter.py::SyncV1RandomSimulatorTestCase::test_sync_rate_limiter - twisted.trial.unittest.FailTest: 7 != 8.This test fails when there's a pending call to
send_tips()after simulation.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged