-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(scripts): modularize script files #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efeac28
to
74afb2a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 85.08% 85.07% -0.02%
==========================================
Files 276 284 +8
Lines 22514 22576 +62
Branches 3430 3430
==========================================
+ Hits 19157 19207 +50
- Misses 2674 2683 +9
- Partials 683 686 +3
☔ View full report in Codecov by Sentry. |
74afb2a
to
091fb01
Compare
091fb01
to
cd51805
Compare
msbrogli
requested changes
Oct 24, 2023
0819fb0
to
f21aa10
Compare
msbrogli
requested changes
Oct 27, 2023
ac68a8d
to
97bbcc4
Compare
msbrogli
previously approved these changes
Oct 27, 2023
msbrogli
approved these changes
Oct 27, 2023
ec5adde
to
e5a19b7
Compare
jansegre
approved these changes
Nov 6, 2023
e5a19b7
to
7c774b1
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor code so the single
scripts.py
file is broken into multiple modules, improving organization and maintainability. No behavior is changed by this PR, code is only moved between files. The only active changes are in imports to fix circular dependencies after the refactor.Acceptance Criteria
scripts
file moved to eitherconstruct
orexecute
modulesChecklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged