Skip to content

chore: improve push_tx log #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

chore: improve push_tx log #806

merged 1 commit into from
Oct 11, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 6, 2023

Motivation

The /push_tx API currently generates alerts when it fails. It should simply log the reason, but not generate an alert. For more info, read https://github.com/HathorNetwork/on-call-incidents/issues/97.

Acceptance Criteria

  • Substitute exc_info by an human-readable message from the warning logged by /push_tx. By removing the "Traceback" from the log, an alert is not fired anymore.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 6, 2023
@glevco glevco marked this pull request as ready for review October 6, 2023 20:04
@glevco glevco requested a review from luislhl October 6, 2023 20:04
luislhl
luislhl previously approved these changes Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c700dc5) 84.65% compared to head (fd3c1ff) 84.66%.
Report is 3 commits behind head on master.

❗ Current head fd3c1ff differs from pull request most recent head e2db317. Consider uploading reports for the commit e2db317 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   84.65%   84.66%           
=======================================
  Files         264      264           
  Lines       22034    22034           
  Branches     3369     3369           
=======================================
+ Hits        18652    18654    +2     
+ Misses       2726     2725    -1     
+ Partials      656      655    -1     
Files Coverage Δ
hathor/builder/builder.py 91.02% <ø> (ø)
hathor/builder/cli_builder.py 74.48% <ø> (ø)
hathor/transaction/resources/push_tx.py 88.04% <100.00%> (ø)
hathor/manager.py 80.95% <54.16%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

msbrogli
msbrogli previously approved these changes Oct 9, 2023
luislhl
luislhl previously approved these changes Oct 10, 2023
@glevco glevco dismissed stale reviews from luislhl and msbrogli via fd3c1ff October 10, 2023 19:02
@glevco glevco force-pushed the chore/improve-push-tx-log branch from fd3c1ff to e2db317 Compare October 10, 2023 20:39
@glevco glevco force-pushed the chore/improve-push-tx-log branch from e2db317 to 67085e3 Compare October 10, 2023 20:40
@glevco glevco merged commit 67085e3 into master Oct 11, 2023
@glevco glevco deleted the chore/improve-push-tx-log branch October 11, 2023 17:29
This was referenced Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants