-
Notifications
You must be signed in to change notification settings - Fork 29
chore: improve push_tx log #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
=======================================
Coverage 84.65% 84.66%
=======================================
Files 264 264
Lines 22034 22034
Branches 3369 3369
=======================================
+ Hits 18652 18654 +2
+ Misses 2726 2725 -1
+ Partials 656 655 -1
☔ View full report in Codecov by Sentry. |
ef89236
to
bd854c1
Compare
fd3c1ff
to
e2db317
Compare
e2db317
to
67085e3
Compare
Motivation
The
/push_tx
API currently generates alerts when it fails. It should simply log the reason, but not generate an alert. For more info, read https://github.com/HathorNetwork/on-call-incidents/issues/97.Acceptance Criteria
exc_info
by an human-readable message from the warning logged by/push_tx
. By removing the "Traceback" from the log, an alert is not fired anymore.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged