-
Notifications
You must be signed in to change notification settings - Fork 30
refactor(verification): move block-only verification methods [part 3/5] #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 84.52% 84.62% +0.09%
==========================================
Files 269 269
Lines 22308 22296 -12
Branches 3401 3401
==========================================
+ Hits 18856 18868 +12
+ Misses 2777 2760 -17
+ Partials 675 668 -7
☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Oct 3, 2023
f407055
to
5b92821
Compare
222e32f
to
6039c40
Compare
00da69d
to
160989e
Compare
6039c40
to
727b499
Compare
160989e
to
2c4f61e
Compare
31d5d85
to
95e2def
Compare
2c4f61e
to
105e059
Compare
95e2def
to
5fd2094
Compare
msbrogli
previously approved these changes
Oct 18, 2023
105e059
to
111621e
Compare
5fd2094
to
2b0c232
Compare
111621e
to
24de4ef
Compare
61cc04b
to
1a5a08a
Compare
Base automatically changed from
refactor/move-verification/method-signatures
to
master
October 24, 2023 21:23
The base branch was changed.
1a5a08a
to
40baa10
Compare
msbrogli
approved these changes
Oct 24, 2023
jansegre
approved these changes
Oct 24, 2023
40baa10
to
94b9075
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #797
Motivation
This is the third PR in a 5-part series of PRs that completely move verification-related code out of the vertex model classes.
This PR moves the verification method implementations of the
Block
inheritance branch.Acceptance Criteria
Block
andMergeMinedBlock
verification methods from the original model classes, moving the implementation to each respectiveVerifier
class. The only exception is theverify_outputs()
method, which is part of the inheritance tree up toBaseTransaction
, and will be moved in a separate PR.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged