Skip to content

refactor(verification): move block-only verification methods [part 3/5] #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Sep 29, 2023

Depends on #797

Motivation

This is the third PR in a 5-part series of PRs that completely move verification-related code out of the vertex model classes.

This PR moves the verification method implementations of the Block inheritance branch.

Acceptance Criteria

  • Remove all Block and MergeMinedBlock verification methods from the original model classes, moving the implementation to each respective Verifier class. The only exception is the verify_outputs() method, which is part of the inheritance tree up to BaseTransaction, and will be moved in a separate PR.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Sep 29, 2023
@glevco glevco changed the title refactor(verification): move block-only verification methods refactor(verification): move block-only verification methods [part 3] Sep 29, 2023
@glevco glevco changed the title refactor(verification): move block-only verification methods [part 3] refactor(verification): move block-only verification methods [part 3/5] Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3365e4b) 84.52% compared to head (94b9075) 84.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   84.52%   84.62%   +0.09%     
==========================================
  Files         269      269              
  Lines       22308    22296      -12     
  Branches     3401     3401              
==========================================
+ Hits        18856    18868      +12     
+ Misses       2777     2760      -17     
+ Partials      675      668       -7     
Files Coverage Δ
hathor/transaction/block.py 94.52% <100.00%> (-0.70%) ⬇️
hathor/transaction/merge_mined_block.py 64.86% <ø> (-4.91%) ⬇️
hathor/verification/block_verifier.py 100.00% <100.00%> (+6.45%) ⬆️
hathor/verification/merge_mined_block_verifier.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review September 29, 2023 20:46
jansegre
jansegre previously approved these changes Oct 3, 2023
@glevco glevco force-pushed the refactor/move-verification/method-signatures branch 2 times, most recently from f407055 to 5b92821 Compare October 10, 2023 02:29
@glevco glevco force-pushed the refactor/move-verification/block-methods branch 2 times, most recently from 222e32f to 6039c40 Compare October 10, 2023 02:53
@glevco glevco force-pushed the refactor/move-verification/method-signatures branch from 00da69d to 160989e Compare October 10, 2023 20:45
@glevco glevco force-pushed the refactor/move-verification/block-methods branch from 6039c40 to 727b499 Compare October 10, 2023 20:51
@glevco glevco force-pushed the refactor/move-verification/method-signatures branch from 160989e to 2c4f61e Compare October 11, 2023 17:36
@glevco glevco force-pushed the refactor/move-verification/block-methods branch from 31d5d85 to 95e2def Compare October 11, 2023 20:33
@glevco glevco force-pushed the refactor/move-verification/method-signatures branch from 2c4f61e to 105e059 Compare October 17, 2023 20:50
@glevco glevco force-pushed the refactor/move-verification/block-methods branch from 95e2def to 5fd2094 Compare October 17, 2023 21:03
msbrogli
msbrogli previously approved these changes Oct 18, 2023
@glevco glevco force-pushed the refactor/move-verification/method-signatures branch from 105e059 to 111621e Compare October 19, 2023 20:29
@glevco glevco force-pushed the refactor/move-verification/block-methods branch from 5fd2094 to 2b0c232 Compare October 19, 2023 20:29
@glevco glevco force-pushed the refactor/move-verification/method-signatures branch from 111621e to 24de4ef Compare October 24, 2023 19:28
@glevco glevco force-pushed the refactor/move-verification/block-methods branch from 61cc04b to 1a5a08a Compare October 24, 2023 19:50
Base automatically changed from refactor/move-verification/method-signatures to master October 24, 2023 21:23
@glevco glevco dismissed stale reviews from msbrogli and jansegre October 24, 2023 21:23

The base branch was changed.

@glevco glevco force-pushed the refactor/move-verification/block-methods branch from 1a5a08a to 40baa10 Compare October 24, 2023 21:26
@glevco glevco force-pushed the refactor/move-verification/block-methods branch from 40baa10 to 94b9075 Compare October 24, 2023 21:45
@glevco glevco merged commit 05f7228 into master Oct 24, 2023
@glevco glevco deleted the refactor/move-verification/block-methods branch October 24, 2023 23:37
@jansegre jansegre mentioned this pull request Nov 13, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants